On Fri, Apr 12, 2024 at 08:46:58PM -0700, Nicolin Chen wrote: > diff --git a/include/linux/iommufd.h b/include/linux/iommufd.h > index ffc3a949f837..a0cb08a4b653 100644 > --- a/include/linux/iommufd.h > +++ b/include/linux/iommufd.h > @@ -9,6 +9,7 @@ > #include <linux/types.h> > #include <linux/errno.h> > #include <linux/err.h> > +#include <linux/refcount.h> > > struct device; > struct iommufd_device; > @@ -18,6 +19,28 @@ struct iommufd_access; > struct file; > struct iommu_group; > > +enum iommufd_object_type { > + IOMMUFD_OBJ_NONE, > + IOMMUFD_OBJ_ANY = IOMMUFD_OBJ_NONE, > + IOMMUFD_OBJ_DEVICE, > + IOMMUFD_OBJ_HWPT_PAGING, > + IOMMUFD_OBJ_HWPT_NESTED, > + IOMMUFD_OBJ_IOAS, > + IOMMUFD_OBJ_ACCESS, > +#ifdef CONFIG_IOMMUFD_TEST > + IOMMUFD_OBJ_SELFTEST, > +#endif > + IOMMUFD_OBJ_MAX, > +}; Can we just forward declare the enum? It would be nice to keep it in the private header Otherwise makes sense Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason