On Tue, Apr 30, 2024 at 09:30:43AM -0700, Nicolin Chen wrote: > > queue_write(Q_ENT(q, cons), cmd, q->ent_dwords); > > Here is the only caller for "msi=false". Maybe we could just do: > + arm_smmu_cmdq_build_sync_cmd(cmd, smmu, q, cons); > > So, no need of "bool msi"? It would slightly change the behavior > though, a SYNC for ARM_SMMU_OPT_MSIPOLL should be still a SYNC. I don't know, I didn't try to figure out what to stick for prod in that case. It is probably OK to convert an error entry into a MSI sync if it works out? Jason
