On Tue, Apr 30, 2024 at 11:24:08AM -0300, Jason Gunthorpe wrote: > On Mon, Apr 29, 2024 at 09:43:46PM -0700, Nicolin Chen wrote: > > The CMDQV extension in NVIDIA Tegra241 SoC resues the arm_smmu_cmdq > > structure while the queue location isn't same as smmu->cmdq. > > > > Add a cmdq argument to arm_smmu_cmdq_init() function and shares its > > define in the header for CMDQV driver to use. > > > > Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx> > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 6 +++--- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 3 +++ > > 2 files changed, 6 insertions(+), 3 deletions(-) > > I would squash this patch and the next together: > > iommu/arm-smm-v3: Make symbols public > > The symbols arm_smmu_cmdq_init() and __arm_smmu_cmdq_skip_err() need > to be used by the tegra241-cmdqv.c compilation unit in the next > patch. Remove the static and put prototypes in the header. > > But the code is fine > > Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Then, arm_smmu_init_one_queue could be moved to this patch too. Thanks Nicolin
