On 25/04/2024 11:07, Mohammad Shehar Yaar Tausif wrote: > Convert NVIDIA Tegra30 I2S binding to DT schema and > add new examples. > > Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@xxxxxxxxx> > --- > Changes v2->v3: > - Fixed example indentation > - Fix compatible logic > - Add new examples from existing dts Why? One different property does not justify new example. I don't think I asked for such change. > - Add clock-names in properties > > v2: > https://lore.kernel.org/all/20240421123037.75680-1-sheharyaar48@xxxxxxxxx/ > --- > .../bindings/sound/nvidia,tegra30-i2s.txt | 27 ------ > .../bindings/sound/nvidia,tegra30-i2s.yaml | 94 +++++++++++++++++++ > 2 files changed, 94 insertions(+), 27 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt > deleted file mode 100644 > index 38caa936f6f8..000000000000 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.txt > +++ /dev/null > @@ -1,27 +0,0 @@ > -NVIDIA Tegra30 I2S controller > - > -Required properties: > -- compatible : For Tegra30, must contain "nvidia,tegra30-i2s". For Tegra124, > - must contain "nvidia,tegra124-i2s". Otherwise, must contain > - "nvidia,<chip>-i2s" plus at least one of the above, where <chip> is > - tegra114 or tegra132. > -- reg : Should contain I2S registers location and length > -- clocks : Must contain one entry, for the module clock. > - See ../clocks/clock-bindings.txt for details. > -- resets : Must contain an entry for each entry in reset-names. > - See ../reset/reset.txt for details. > -- reset-names : Must include the following entries: > - - i2s > -- nvidia,ahub-cif-ids : The list of AHUB CIF IDs for this port, rx (playback) > - first, tx (capture) second. See nvidia,tegra30-ahub.txt for values. > - > -Example: > - > -i2s@70080300 { > - compatible = "nvidia,tegra30-i2s"; > - reg = <0x70080300 0x100>; > - nvidia,ahub-cif-ids = <4 4>; > - clocks = <&tegra_car 11>; > - resets = <&tegra_car 11>; > - reset-names = "i2s"; > -}; > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml > new file mode 100644 > index 000000000000..3d8d56c666d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-i2s.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra30-i2s.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra30 I2S controller > + > +maintainers: > + - Thierry Reding <treding@xxxxxxxxxx> > + - Jon Hunter <jonathanh@xxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - nvidia,tegra124-i2s > + - nvidia,tegra30-i2s > + - items: > + - enum: > + - nvidia,tegra114-i2s > + - nvidia,tegra132-i2s > + - enum: > + - nvidia,tegra124-i2s > + - nvidia,tegra30-i2s > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + maxItems: 1 This was not in the previous binding and is not explained in commit msg. Also, this needs to be specific. > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: i2s > + > + nvidia,ahub-cif-ids: > + description: list of AHUB CIF IDs > + $ref: /schemas/types.yaml#/definitions/uint32-array > + items: > + - description: rx (playback) > + - description: tx (capture) > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - reset-names > + - nvidia,ahub-cif-ids > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/tegra30-car.h> > + > + i2s@70080300 { > + compatible = "nvidia,tegra30-i2s"; > + reg = <0x70080300 0x100>; > + nvidia,ahub-cif-ids = <4 4>; > + clocks = <&tegra_car TEGRA30_CLK_I2S0>; > + resets = <&tegra_car 30>; > + reset-names = "i2s"; > + }; Just keep one or two examples. Best regards, Krzysztof
