Remove the manual refcount management of device_node
and instead, use scope-based resource management.
While the pointer never gets out of scope it reduces
somehow the risk of missing the of_node_put() call.
Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx>
Signed-off-by: Miguel Miranda <mmikernel@xxxxxxxxx>
---
I only have a deprecated jetson nano dev-kit, but need
to test this on hardware. I am exploring options to
build a rootfs to test this using qemu-system-aarch64.
---
drivers/soc/tegra/common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
index dff6d5ef4e46..94d11102d90f 100644
--- a/drivers/soc/tegra/common.c
+++ b/drivers/soc/tegra/common.c
@@ -28,14 +28,12 @@ static const struct of_device_id tegra_machine_match[] = {
bool soc_is_tegra(void)
{
const struct of_device_id *match;
- struct device_node *root;
+ struct device_node *root __free(device_node) = of_find_node_by_path("/");
- root = of_find_node_by_path("/");
if (!root)
return false;
match = of_match_node(tegra_machine_match, root);
- of_node_put(root);
return match != NULL;
}
--
2.25.1
