Hi Krzysztof,
On Sat, Apr 13, 2024 at 10:02:07AM +0200, Krzysztof Kozlowski wrote:
> On 09/04/2024 11:46, Diogo Ivo wrote:
> > Convert the macros that manipulate the delay values to interpret their
> > index parameter as an integer to allow the introduction of loops.
> >
> > Signed-off-by: Diogo Ivo <diogo.ivo@xxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/memory/tegra/tegra210-emc-cc-r21021.c | 33 +++++++------------
> > 1 file changed, 11 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/memory/tegra/tegra210-emc-cc-r21021.c b/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> > index a80c3b575612..65157bd5dc24 100644
> > --- a/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> > +++ b/drivers/memory/tegra/tegra210-emc-cc-r21021.c
> > @@ -75,29 +75,29 @@ enum {
> > * The division portion of the average operation.
> > */
> > #define __AVERAGE_PTFV(dev) \
> > - ({ next->ptfv_list[PTFV_DQSOSC_MOVAVG_ ## dev ## _INDEX] = \
> > - next->ptfv_list[PTFV_DQSOSC_MOVAVG_ ## dev ## _INDEX] / \
> > + ({ next->ptfv_list[dev] = \
> > + next->ptfv_list[dev] / \
>
> Aren't you missing now () over dev?
Yes I am, I'll add it for v2.
> Are you sure this passes checkpatch --strict?
It did :)
Thank you for the review!
Best regards,
Diogo
