On Fri, Apr 05, 2024 at 04:09:05PM +0200, Marc Dietrich wrote: > The i2c controller needs to read back the data written to its registers. > This way we can avoid the long delay in the interrupt handler. > > Signed-off-by: Marc Dietrich <marvin24@xxxxxx> > --- > drivers/staging/nvec/nvec.c | 39 +++++++++++++++++++++---------------- > 1 file changed, 22 insertions(+), 17 deletions(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 282a664c9176..9914c30b6933 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -565,6 +565,20 @@ static void nvec_tx_set(struct nvec_chip *nvec) > (uint)nvec->tx->size, nvec->tx->data[1]); > } > > +/** > + * i2c_writel - savely write to an i2c client controller register > + @ val: value to be written > + @ reg: register to write to > + */ > + > +static void i2c_writel(u32 val, void *reg) I'm not a expert at kernel doc or whatever, but this comment isn't in the right format. And delete the blank line between the comment and the function. /** * i2c_writel - savely write to an i2c client controller register * @ val: value to be written * @ reg: register to write to */ static void i2c_writel(u32 val, void *reg) regards, dan carpenter
