On Fri, Feb 02, 2024 at 12:53:34PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > In many cases the AXI configuration can be derived from the compatible > string, so there's no need to add the configuration to DT. Allow drivers > to pass in the default AXI configuration so they can be properly set up > without extra data in DT. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 650ec8d2f5d7..0d5f2cebd6fc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -91,34 +91,49 @@ static int dwmac1000_validate_ucast_entries(struct device *dev, > * if required, from device-tree the AXI internal register can be tuned > * by using platform parameters. > */ > -static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) > +static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev, > + struct stmmac_resources *res) Hi Thierry, Please consider adding @res to the kernel doc for stmmac_axi_setup, just a few lines above this hunk. ...
