On Wed, Jan 24, 2024 at 11:46:59AM +0000, Robin Murphy wrote:
> > > > This may be connected with an error in of_iommu_configure() that
> > > > became visible after commit 6ff6e184f1f4d:
> > > >
> > > > [ 1.200004] host1x drm: iommu configuration for device failed with -ENOENT
> > >
> > > Hmmm
> > >
> > > This is a new logging, so it doesn't necessarily mean something has
> > > changed in the code flow.
> > >
> > > It seems the issue is something in there is returning ENOENT when it
> > > probably should be ENODEV, but I haven't been able to guess where it
> > > comes from.
> > >
> > > Can you do some tracing and figure out where under
> > > of_iommu_configure() this ENOENT return code is from?
> >
> > I did the tracing and found that the ENOENT is coming from
> > sysfs_do_create_link_sd() in the following function call chain:
> >
> > of_iommu_configure() -> iommu_probe_device() -> __iommu_probe_device() ->
>
> What's the call path leading up to that? If it's the one from
> host1x_device_add() then it's expected and benign - for fiddly reasons,
> iommu_probe_device() ends up being called too early, but will soon be run
> again in the correct circumstances once we proceed into
> host1x_subdev_register()->device_add(). That will have been happening for
> years, we just never reported errors in that spot before (and frankly I'm
> not convinced it's valuable to have added it now).
Hmm. Prior to
commit 14891af3799e ("iommu: Move the iommu driver sysfs setup into
iommu_init/deinit_device()")
The error from iommu_device_link() was ignored. It seems like for most
of the years the probe actually succeeded, just with a mangled sysfs?
Though that host1x_device_add() ignored the return code does make me
wonder..
This is the only clue I see:
commit c95469aa5a188384ccf8ac520ece931c66caf8aa
Author: Alexandre Courbot <acourbot@xxxxxxxxxx>
Date: Fri Feb 26 18:06:53 2016 +0900
gpu: host1x: Set DMA ops on device creation
Currently host1x-instanciated devices have their dma_ops left to NULL,
which makes any DMA operation (like buffer import) on ARM64 fallback
to the dummy_dma_ops and fail with an error.
This patch calls of_dma_configure() with the host1x node when creating
such a device, so the proper DMA operations are set.
Suggested-by: Thierry Reding <thierry.reding@xxxxxxxxx>
Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
Which is no longer happening anymore as failure of
iommu_probe_device() will not cause the dma ops to be setup.
So, if everything still works and something else is calling
of_dma_configure() prior to using the struct device for any DMA
operations (eg because a driver is always probed?) then we should just
delete this call.
Robin do you know more? Specifically where is the "soon be run again"?
Was the above issue fixed in commit 07397df29e57 ("dma-mapping: move
dma configuration to bus infrastructure") ?
Jason
