On 10/26/23 12:53 AM, Harshit Mogalapalli wrote: > The value of 'ret' is zero when of_hte_req_count() fails to get number > of entitties to timestamp. And returning success(zero) on this failure > path is incorrect. > > Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> > --- > This is found using static analysis with smatch, only compile tested. > --- > drivers/hte/hte-tegra194-test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c > index ba37a5efbf82..ab2edff018eb 100644 > --- a/drivers/hte/hte-tegra194-test.c > +++ b/drivers/hte/hte-tegra194-test.c > @@ -153,8 +153,10 @@ static int tegra_hte_test_probe(struct platform_device *pdev) > } > > cnt = of_hte_req_count(hte.pdev); > - if (cnt < 0) > + if (cnt < 0) { > + ret = cnt; > goto free_irq; > + } > > dev_info(&pdev->dev, "Total requested lines:%d\n", cnt); > Reviewed-by: Dipen Patel <dipenp@xxxxxxxxxx>