On 10/10/23 8:17 AM, Andy Shevchenko wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/hte/hte-tegra194.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 339ff5921ec8..30ef1750a9fa 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> ret = platform_get_irq(pdev, 0);
> - if (ret < 0) {
> - dev_err_probe(dev, ret, "failed to get irq\n");
> + if (ret < 0)
> return ret;
> - }
> hte_dev->hte_irq = ret;
> ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
> dev_name(dev), hte_dev);
Reviewed-by: Dipen Patel <dipenp@xxxxxxxxxx>
