On Mon, Oct 09, 2023 at 10:38:58AM -0700, Dipen Patel wrote: Tbank you! My comments below. > Any driver that depends on the GPIO match function to locate the GPIO > controller, it has to use the fwnode from the gpio_chip structure. But > with [1], it is GPIO providers job to set any members of the gpio_chip > structure. This patch addresses that. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/pateldipen1984/linux.git/patch/drivers/gpio/gpiolib.c?id=daecca4b8433d47f0db4933bcc0f283d530ba22e Use Link: tag for this? ... > + /* > + * This is needed for driver using gpio device matching where it > + * has to use gpio_chip fwnode to match the gpio controller. > + */ > + gpio->gpio.fwnode = of_node_to_fwnode(pdev->dev.of_node); of_node_to_fwnode() is specific to IRQ, in other places we use generic of_fwnode_handle(). That's why better just to use dev_fwnode(). ... With the above addressed: Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> -- With Best Regards, Andy Shevchenko
