On 8/1/23 7:01 AM, Zhu Wang wrote:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to print error, we remove the
> redundant platform_get_irq().
The commit message needs to be improved. It is ok to remove the "we remove the
redundant plaform_get_irq line". Otherwise it looks ok to me.
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> ---
> drivers/hte/hte-tegra194.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 06ef349a2265..01f416c881e6 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -730,7 +730,6 @@ static int tegra_hte_probe(struct platform_device *pdev)
>
> ret = platform_get_irq(pdev, 0);
> if (ret < 0) {
> - dev_err_probe(dev, ret, "failed to get irq\n");
> return ret;
> }
> hte_dev->hte_irq = ret;
