On 9/11/23 2:44 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Using any of the GPIO interfaces using the global numberspace is > deprecated. Make it clear in the comment. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > This was part of a wider series but since this is independent, I'm sending > it separately. > > drivers/hte/hte-tegra194.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c > index 6fe6897047ac..9fd3c00ff695 100644 > --- a/drivers/hte/hte-tegra194.c > +++ b/drivers/hte/hte-tegra194.c > @@ -407,12 +407,15 @@ static int tegra_hte_line_xlate(struct hte_chip *gc, > return -EINVAL; > > /* > + * GPIO consumers can access GPIOs in two ways: > * > - * There are two paths GPIO consumers can take as follows: > - * 1) The consumer (gpiolib-cdev for example) which uses GPIO global > - * number which gets assigned run time. > - * 2) The consumer passing GPIO from the DT which is assigned > - * statically for example by using TEGRA194_AON_GPIO gpio DT binding. > + * 1) Using the global GPIO numberspace. > + * > + * This is the old, now DEPRECATED method and should not be used in > + * new code. TODO: Check if tegra is even concerned by this. This use case is to do namespace mapping from gpio subsystem to hte. Few doubts: 1. What does deprecate mean here? Does gpio subsys not use global space anymore? 2. If yes, what GPIO number is set when it comes from gpiolib-cdev, as based on that I may have to reflect in the mapping, tegra194_aon_gpio_map for example. > + * > + * 2) Using GPIO descriptors that can be assigned to consumer devices > + * using device-tree, ACPI or lookup tables. > * > * The code below addresses both the consumer use cases and maps into > * HTE/GTE namespace.
