Re: [Patch v2 2/2] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Sumit,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v6.6-rc1 next-20230913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: linux-next
patch link:
patch subject: [Patch v2 2/2] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241
config: i386-defconfig (
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes:

All warnings (new ones prefixed by >>):

drivers/acpi/processor_thermal.c:141:6: warning: no previous declaration for 'acpi_thermal_cpufreq_config_nvidia' [-Wmissing-declarations]
     void acpi_thermal_cpufreq_config_nvidia(void)

Thank you for the report.
The below change fixes the warning for me.

 -void acpi_thermal_cpufreq_config_nvidia(void)
 +static void acpi_thermal_cpufreq_config_nvidia(void)

Hi Rafael,
If there is no other comment. Could you please add the change while applying or you prefer me sending new version ?

Thank you,
Sumit Gupta

vim +/acpi_thermal_cpufreq_config_nvidia +141 drivers/acpi/processor_thermal.c

  > 141  void acpi_thermal_cpufreq_config_nvidia(void)
    142  {
    144          s32 soc_id = arm_smccc_get_soc_id_version();
    146          /* Check JEP106 code for NVIDIA Tegra241 chip (036b:0241) */
    147          if ((soc_id < 0) || (soc_id != SMCCC_SOC_ID_T241))
    148                  return;
    150          /* Reduce the CPUFREQ Thermal reduction percentage to 5% */
    151          cpufreq_thermal_pctg = 5;
    153          /*
    154           * Derive the MAX_STEP from minimum throttle percentage so that the reduction
    155           * percentage doesn't end up becoming negative. Also, cap the MAX_STEP so that
    156           * the CPU performance doesn't become 0.
    157           */
    158          cpufreq_thermal_max_step = ((100 / cpufreq_thermal_pctg) - 1);
    159  #endif
    160  }

0-DAY CI Kernel Test Service

[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux