On Thu, Sep 07, 2023 at 12:40:49PM +0530, Kartik wrote:
> Add helper function tegra_fuse_add_lookups() to register Tegra fuse
> nvmem lookups. So, this can be shared between tegra_fuse_init() and
> ACPI probe, which is to be introduced later.
...
> +static int tegra_fuse_add_lookups(struct tegra_fuse *fuse)
> +{
> + size_t size;
> +
> + if (!fuse->soc->lookups)
> + return 0;
> + size = size_mul(sizeof(*fuse->lookups), fuse->soc->num_lookups);
> +
> + fuse->lookups = kmemdup(fuse->soc->lookups, size, GFP_KERNEL);
> + if (!fuse->lookups)
> + return -ENOMEM;
Why not introducing kmemdup_array()?
> + nvmem_add_cell_lookups(fuse->lookups, fuse->soc->num_lookups);
> +
> + return 0;
> +}
...
> + err = tegra_fuse_add_lookups(fuse);
> + if (err) {
> + pr_err("failed to add FUSE lookups\n");
Why pr_err() and not dev_err()?
> + return err;
> }
>
> return 0;
These four lines can be just shortened to
return err;
--
With Best Regards,
Andy Shevchenko
