On 28/08/23 15:47, Viresh Kumar wrote:
External email: Use caution opening links or attachments
On 28-08-23, 11:41, Viresh Kumar wrote:
On 25-08-23, 16:46, Sumit Gupta wrote:
Add exit hook and remove OPP table when the device gets unregistered.
This will fix the error messages when the CPU FREQ driver module is
removed and then re-inserted. It also fixes these messages while
onlining the first CPU from a policy whose all CPU's were previously
offlined.
debugfs: File 'cpu5' in directory 'opp' already present!
debugfs: File 'cpu6' in directory 'opp' already present!
debugfs: File 'cpu7' in directory 'opp' already present!
Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
Signed-off-by: Sumit Gupta <sumitg@xxxxxxxxxx>
---
v1[1] -> v2:
- updated commit description.
[1] https://lore.kernel.org/lkml/20230809153455.29056-1-sumitg@xxxxxxxxxx/
drivers/cpufreq/tegra194-cpufreq.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index c90b30469165..66a9c23544db 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -454,6 +454,8 @@ static int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
if (ret < 0)
return ret;
+ dev_pm_opp_put(opp);
+
Missed this earlier, can you please do this in a separate patch please
?
I have pushed rest of this commit and dropped this part. Send it
separately. Thanks.
--
viresh
Thank you.
Sent the change separately @
https://lore.kernel.org/lkml/20230828120959.24680-1-sumitg@xxxxxxxxxx/
Regards,
Sumit Gupta
