On Fri, Aug 18, 2023 at 03:00:28PM +0530, Kartik wrote: > Add support for Tegra241 which use ACPI boot. ... > case TEGRA234: > fuse->soc = &tegra234_fuse_soc; > break; > +#endif > +#if defined(CONFIG_ARCH_TEGRA_241_SOC) > + case TEGRA241: > + fuse->soc = &tegra241_fuse_soc; > + break; > #endif Have you tried --patience when formatting patches? Does it help them to look better? ... > +const struct tegra_fuse_soc tegra241_fuse_soc = { > + .init = tegra30_fuse_init, > + .info = &tegra241_fuse_info, > + .lookups = NULL, > + .num_lookups = 0, > + .cells = NULL, > + .num_cells = 0, Isn't it the default? > + .keepouts = tegra241_fuse_keepouts, > + .num_keepouts = ARRAY_SIZE(tegra241_fuse_keepouts), > + .soc_attr_group = &tegra194_soc_attr_group, > + .clk_suspend_on = false, Ditto. > +}; -- With Best Regards, Andy Shevchenko