Hi Parker,
On Tue, Aug 08, 2023 at 12:42:28PM +0000, Parker Newman wrote:
> On 2023-08-06 10:21, Akhil R wrote:
> >>
> >> BTW...
> >>
> >> On Thu, Aug 03, 2023 at 05:10:02PM +0000, Parker Newman wrote:
> >>>
> >>
> >> you have a blank line here.
> >>
> >>> This patch fixes the Tegra DMA config option processing in the
> >>> i2c-tegra driver.
> >>>
> >>> Tegra processors prior to Tegra186 used APB DMA for I2C requiring
> >>> CONFIG_TEGRA20_APB_DMA=y while Tegra186 and later use GPC DMA
> >>> requiring CONFIG_TEGRA186_GPC_DMA=y.
> >>>
> >>> The check for if the processor uses APB DMA is inverted and so the
> >>> wrong DMA config options are checked.
> >>>
> >>> This means if CONFIG_TEGRA20_APB_DMA=y but
> >> CONFIG_TEGRA186_GPC_DMA=n
> >>> with a Tegra186 or later processor the driver will incorrectly think
> >>> DMA is enabled and attempt to request DMA channels that will never be
> >>> availible, leaving the driver in a perpetual EPROBE_DEFER state.
> >>>
> >>> Signed-off-by: Parker Newman <pnewman@xxxxxxxxxxxxxxx>
> >>
> >> As this is a fix you also need to add
> >>
> >> Fixes: 48cb6356fae1 ("i2c: tegra: Add GPCDMA support")
> >> Cc: Akhil R <akhilrajeev@xxxxxxxxxx>
> >> Cc: <stable@xxxxxxxxxxxxxxx> # v6.1+
> >>
> >> Cc'eing Akhil as well for his opinion on this.
> > The fix looks valid to me. Must have been a typo there.
> >
> > Regards,
> > Akhil
> >
> Yes it appears to be a simple typo and if you have both DMA Config options
> set the bug would get missed.
>
> I am new to the Linux mailing list, should I send a new message to
> stable@xxxxxxxxxxxxxxx or CC them on this one?
First of all... welcome to the Linux mailing list :)
No need to resend, I can add it... I was hoping for an official
ack, but as that's not coming, I will ack it
Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Thank you Parker and wishing to see more patches from you ;)
Andi
