17.07.2023 16:25, Thierry Reding пишет: > On Mon, Jul 17, 2023 at 11:50:03AM +0300, Dmitry Osipenko wrote: >> 17.07.2023 10:16, Thierry Reding пишет: >>> For cases where the timings are the only things that differ, the DT >>> bindings allow overriding the timings specifically. So you might get >>> away with using one of the existing panels if it is close enough and >>> patch up the timings in DT. >> >> If panel-simple supported timings override from DT, then panel-lvds >> indeed could be removed. But panel-simple doesn't support it: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a21f18a993c56566db94ba836684bc32c070a82c > > I clearly didn't look at that patch closely enough. panel-simple has > supported override modes since: > > commit b8a2948fa2b3a5a6da67fd57aa01c7318d795125 > Author: Sean Paul <seanpaul@xxxxxxxxxxxx> > Date: Thu Jul 11 13:34:53 2019 -0700 > > drm/panel: simple: Add ability to override typical timing > > This patch adds the ability to override the typical display timing for a > given panel. This is useful for devices which have timing constraints > that do not apply across the entire display driver (eg: to avoid > crosstalk between panel and digitizer on certain laptops). The rules are > as follows: > > - panel must not specify fixed mode (since the override mode will > either be the same as the fixed mode, or we'll be unable to > check the bounds of the overried) > - panel must specify at least one display_timing range which will be > used to ensure the override mode fits within its bounds > > Changes in v2: > - Parse the full display-timings node (using the native-mode) (Rob) > Changes in v3: > - No longer parse display-timings subnode, use panel-timing (Rob) > Changes in v4: > - Don't add mode from timing if override was specified (Thierry) > - Add warning if timing and fixed mode was specified (Thierry) > - Don't add fixed mode if timing was specified (Thierry) > - Refactor/rename a bit to avoid extra indentation from "if" tests > - i should be unsigned (Thierry) > - Add annoying WARN_ONs for some cases (Thierry) > - Simplify 'No display_timing found' handling (Thierry) > - Rename to panel_simple_parse_override_mode() (Thierry) > Changes in v5: > - Added Heiko's Tested-by > Changes in v6: > - Rebased to drm-misc next > - Added tags > > Cc: Doug Anderson <dianders@xxxxxxxxxxxx> > Cc: Eric Anholt <eric@xxxxxxxxxx> > Cc: Heiko Stuebner <heiko@xxxxxxxxx> > Cc: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Stéphane Marchesin <marcheu@xxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20190711203455.125667-2-dianders@xxxxxxxxxxxx > > Looking at the error message cited in the linked commit, the problem is > that the Chunghwa panel has a fixed mode listed in the driver. However I > don't see a reason why we can't get rid of that. The only place where I > can find the compatible string for that used is for the Nexus 7, so we > should be able to replace the fixed mode with the timings for that panel > and remove the fixed mode. > > The initial Chunghwa panel driver support doesn't seem to have been > based on the Nexus 7, so I suppose if we make the above change we could > technically be breaking some setup out there, but since we have no way > of knowing which device this was on, or if anybody still has access, the > best we can do is hope that nothing breaks and fix things up if somebody > complains. Sounds good. For the Chunghwa there is no other user than N7 in upstream kernel, nothing to worry about. Indeed, it should be timing ranges and not the fixed mode. For the Hydis panel there is no definition in panel-simple, it needs to be added. It also should be in a form of timing ranges, though I don't see ranges in the datasheet, not sure where to get them.
