Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

thanks for the feedback!

On Tue, 18 Jul 2023 at 06:46, Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> wrote:
> 15.07.2023 10:53, Benjamin Bara пишет:
> >
> > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
> > Acked-for-MFD-by: Lee Jones <lee@xxxxxxxxxx>
>
> Acked-for-MFD-by isn't a valid tag, scripts/checkpatch.pl should tell
> you about it.
>
> In general you may add a comment to a tag, like this:
>
>   Acked-by: Lee Jones <lee@xxxxxxxxxx> # for MFD
>
> In this particular case, the comment is unnecessary because Lee is the
> MFD maintainer, hence his ack itself implies the MFD subsys.

I saw the warning, but Lee requested to add it like this [1].

@Konstantin:
Do you think it makes sense to print a warning when adding "non-standard
trailers" during running "b4 trailers -u", maybe around the
find_trailers() checks? I could provide a RFC, if considered useful.

Best regards,
Benjamin

[1] https://lore.kernel.org/all/20230518094434.GD404509@xxxxxxxxxx/



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux