On Mon, Jul 17, 2023 at 10:57 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote: > Le lundi 17 juillet 2023 à 22:36 +0300, Andy Shevchenko a écrit : > > On Mon, Jul 17, 2023 at 10:07 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > wrote: > > > Le lundi 17 juillet 2023 à 20:28 +0300, Andy Shevchenko a écrit : ... > > > > +DEFINE_NOIRQ_DEV_PM_OPS(mtk_paris_pinctrl_pm_ops, > > > > mtk_paris_suspend, > > > > mtk_paris_resume); > > > > > > It's a bit more work, but I think you should use > > > EXPORT_GPL_DEV_PM_OPS > > > (or even better, EXPORT_NS_GPL_DEV_PM_OPS) so that the dev_pm_ops > > > is > > > conditionally exported. All callers would have to be updated to use > > > pm_ptr(). > > > > Why pm_ptr()? What did I miss? > > The rest is OK. > > Or pm_sleep_ptr(). As I said in my answer to the other patch, > EXPORT_*_DEV_PM_OPS() currently only exports on CONFIG_PM, so it > doesn't really matter which one you use. Yes, I need to think about it. I don't like the inconsistency the EXPORT*PM_OPS() brings in this case. -- With Best Regards, Andy Shevchenko
