On 14/07/23 11:20 pm, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > drivers/staging/most/dim2/dim2.c | 2 +- Acked-by: Parthiban Veerasooran <parthiban.veerasooran@xxxxxxxxxxxxx> > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > index 44d3252d4612..ed6a9cc88541 100644 > --- a/drivers/staging/most/dim2/dim2.c > +++ b/drivers/staging/most/dim2/dim2.c > @@ -8,7 +8,6 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include <linux/module.h> > -#include <linux/of_platform.h> > #include <linux/printk.h> > #include <linux/kernel.h> > #include <linux/init.h> > @@ -21,6 +20,7 @@ > #include <linux/sched.h> > #include <linux/kthread.h> > #include <linux/most.h> > +#include <linux/of.h> > #include "hal.h" > #include "errors.h" > #include "sysfs.h" > -- > 2.40.1 >
