Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Mon, 17 Jul 2023 22:27:26 +0300
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Balsam CHIHI <bchihi@xxxxxxxxxxxx>, Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, Andy Shevchenko <andy@xxxxxxxxxx>, Sean Wang <sean.wang@xxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Gregory Clement <gregory.clement@xxxxxxxxxxx>, Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>, Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>
In-reply-to: <73161288a07eb34a458061151d9d9a5c10d79c1b.camel@crapouillou.net>
References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> <20230717172821.62827-4-andriy.shevchenko@linux.intel.com> <73161288a07eb34a458061151d9d9a5c10d79c1b.camel@crapouillou.net>

On Mon, Jul 17, 2023 at 10:22 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:
> Le lundi 17 juillet 2023 à 20:28 +0300, Andy Shevchenko a écrit :

...

> > +static DEFINE_NOIRQ_DEV_PM_OPS(chv_pinctrl_pm_ops,
> > chv_pinctrl_suspend_noirq, chv_pinctrl_resume_noirq);
>
> That's over 100 characters, please break this line.

If it's a problem, I prefer to shorten the names of the callbacks.
Would it work for you?

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
  - From: Paul Cercueil

References:
- [PATCH v2 00/10] pinctrl: Provide NOIRQ PM helper and use it
  - From: Andy Shevchenko
- [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
  - From: Andy Shevchenko
- Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
  - From: Paul Cercueil

Prev by Date: Re: [PATCH v2 08/10] pinctrl: mvebu: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
Next by Date: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
Previous by thread: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
Next by thread: Re: [PATCH v2 03/10] pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
Index(es):
- Date
- Thread

[Index of Archives] [ARM Kernel] [Linux ARM] [Linux ARM MSM] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]