On Thu, Jul 13, 2023 at 01:51:06PM +0530, Prathamesh Shete wrote:
> The current function for a given pin is not displayed via the debugfs.
> Add support to display the current function that is set for each pin.
>
> Signed-off-by: Prathamesh Shete <pshete@xxxxxxxxxx>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 19 +++++++++++++++++--
> drivers/pinctrl/tegra/pinctrl-tegra.h | 2 ++
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 4547cf66d03b..4da8873942cf 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -96,6 +96,7 @@ static const struct cfg_param {
> {"nvidia,slew-rate-falling", TEGRA_PINCONF_PARAM_SLEW_RATE_FALLING},
> {"nvidia,slew-rate-rising", TEGRA_PINCONF_PARAM_SLEW_RATE_RISING},
> {"nvidia,drive-type", TEGRA_PINCONF_PARAM_DRIVE_TYPE},
> + {"nvidia,function", TEGRA_PINCONF_PARAM_FUNCTION},
> };
>
> static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
> @@ -470,6 +471,12 @@ static int tegra_pinconf_reg(struct tegra_pmx *pmx,
> *bit = g->drvtype_bit;
> *width = 2;
> break;
> + case TEGRA_PINCONF_PARAM_FUNCTION:
> + *bank = g->mux_bank;
> + *reg = g->mux_reg;
> + *bit = g->mux_bit;
> + *width = 2;
> + break;
> default:
> dev_err(pmx->dev, "Invalid config param %04x\n", param);
> return -ENOTSUPP;
> @@ -620,6 +627,7 @@ static void tegra_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
> s8 bank, bit, width;
> s32 reg;
> u32 val;
> + u8 idx;
This declaration could be moved into the only conditional that uses this
variable...
>
> g = &pmx->soc->groups[group];
>
> @@ -633,8 +641,15 @@ static void tegra_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
> val >>= bit;
> val &= (1 << width) - 1;
>
> - seq_printf(s, "\n\t%s=%u",
> - strip_prefix(cfg_params[i].property), val);
> + if (cfg_params[i].param == TEGRA_PINCONF_PARAM_FUNCTION) {
> + idx = pmx->soc->groups[group].funcs[val];
... so that this would become:
u8 idx = ...;
Either way:
Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
