On Fri, Jul 14, 2023 at 03:21:47AM +0000, 杜敏杰 wrote: > Hi Baolu! > > It seems that 'smmu->debugfs' check is still needed. > Then I will modify the patch. > Thanks! > > regards, > Minjie Don't top-post, please. See Documentation/process/2.Process.rst and Documentation/process/submitting-patches.rst. Also, how did you come to the above conclusion? Baolu said that Greg keeps reminding people that we shouldn't do error handling for debugfs and gave a Reviewed-by:, so why the 180? Thierry > -----邮件原件----- > 发件人: Baolu Lu <baolu.lu@xxxxxxxxxxxxxxx> > 发送时间: 2023年7月14日 10:58 > 收件人: 杜敏杰 <duminjie@xxxxxxxx>; Thierry Reding <thierry.reding@xxxxxxxxx>; Krishna Reddy <vdumpa@xxxxxxxxxx>; Joerg Roedel <joro@xxxxxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Robin Murphy <robin.murphy@xxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; open list:TEGRA IOMMU DRIVERS <linux-tegra@xxxxxxxxxxxxxxx>; open list:IOMMU SUBSYSTEM <iommu@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx> > 抄送: baolu.lu@xxxxxxxxxxxxxxx; opensource.kernel <opensource.kernel@xxxxxxxx>; Thierry Reding <treding@xxxxxxxxxx> > 主题: Re: [PATCH v4] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() > > [Some people who received this message don't often get email from baolu.lu@xxxxxxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > On 2023/7/13 15:28, Minjie Du wrote: > > debugfs_create_file() will return early if smmu->debugfs is an error > > pointer, so an extra error check is not needed. > > > > Signed-off-by: Minjie Du<duminjie@xxxxxxxx> > > Acked-by: Thierry Reding<treding@xxxxxxxxxx> > > Greg keeps reminding that no error branch for debugfs, so > > Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > > Best regards, > baolu
Attachment:
signature.asc
Description: PGP signature
