On Wed, Jul 05, 2023 at 08:49:02AM +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
>
> Correct the interrupt flags to a value used also in Tegra30 Beaver board
> with this device.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sameer,
I can help test this if you're busy, but I don't know how to test
whether this work correctly. Can you share how we can validate this?
Thierry
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> index 64a3398fe7a6..7c400e024332 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> @@ -2115,7 +2115,7 @@ rt5658: audio-codec@1a {
> compatible = "realtek,rt5658";
> reg = <0x1a>;
> interrupt-parent = <&gpio>;
> - interrupts = <TEGRA194_MAIN_GPIO(S, 5) GPIO_ACTIVE_HIGH>;
> + interrupts = <TEGRA194_MAIN_GPIO(S, 5) IRQ_TYPE_EDGE_FALLING>;
> clocks = <&bpmp TEGRA194_CLK_AUD_MCLK>;
> clock-names = "mclk";
> realtek,jd-src = <2>;
> --
> 2.34.1
>
Attachment:
signature.asc
Description: PGP signature
