On 11/07/2023 09:07, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 23:11 schrieb Dmitry Baryshkov:
[...]
---
drivers/gpu/drm/armada/armada_fbdev.c | 4 ----
drivers/gpu/drm/drm_client.c | 21 +++++++++++++++++++++
drivers/gpu/drm/drm_fbdev_dma.c | 4 ----
drivers/gpu/drm/drm_fbdev_generic.c | 4 ----
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 ----
drivers/gpu/drm/gma500/fbdev.c | 4 ----
drivers/gpu/drm/msm/msm_fbdev.c | 4 ----
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> # msm
Thanks.
drivers/gpu/drm/omapdrm/omap_fbdev.c | 4 ----
drivers/gpu/drm/radeon/radeon_fbdev.c | 4 ----
drivers/gpu/drm/tegra/fbdev.c | 4 ----
10 files changed, 21 insertions(+), 36 deletions(-)
BTW: As you have been clearing this area. I see that significant
amount of DRM drivers use exactly the same code for
msm_fbdev_client_funcs and for the significant part of
foo_fbdev_setup(). Do you have any plans for moving that into a
library / generic code? If not, I can take a look at crafting the patch.
You're not the first to ask. :) I've so far not attempted to address
this duplication. I've been bitten by premature helperization before, so
I wanted to wait a bit longer. A lot of the fbdev and client code is
changing quite a bit. After things stabilized, I want to to try to do
some more code sharing.
Ack, thank you for sharing this.
--
With best wishes
Dmitry
