Re: [PATCH 4/4] net: phy: aqr113c: Enable Wake-on-LAN (WOL)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Revanth,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master horms-ipvs/master v6.4 next-20230628]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Revanth-Kumar-Uppala/net-phy-aquantia-Enable-MAC-Controlled-EEE/20230628-204746
base:   net/main
patch link:    https://lore.kernel.org/r/20230628124326.55732-4-ruppala%40nvidia.com
patch subject: [PATCH 4/4] net: phy: aqr113c: Enable Wake-on-LAN (WOL)
config: i386-randconfig-i013-20230628 (https://download.01.org/0day-ci/archive/20230629/202306290253.b8D3gQf8-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230629/202306290253.b8D3gQf8-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306290253.b8D3gQf8-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/net/phy/aquantia_main.c: In function 'aqr_handle_interrupt':
>> drivers/net/phy/aquantia_main.c:476:29: warning: unused variable 'priv' [-Wunused-variable]
     476 |         struct aqr107_priv *priv = phydev->priv;
         |                             ^~~~


vim +/priv +476 drivers/net/phy/aquantia_main.c

   473	
   474	static irqreturn_t aqr_handle_interrupt(struct phy_device *phydev)
   475	{
 > 476		struct aqr107_priv *priv = phydev->priv;
   477		int irq_status;
   478		int ret;
   479	
   480		ret = phy_read_mmd(phydev, MDIO_MMD_C22EXT, MDIO_C22EXT_GBE_PHY_SGMII_TX_ALARM1);
   481		if (ret < 0) {
   482			phy_error(phydev);
   483			return IRQ_NONE;
   484		}
   485	
   486		if ((ret & MDIO_C22EXT_SGMII0_MAGIC_PKT_FRAME_MASK) ==
   487		    MDIO_C22EXT_SGMII0_MAGIC_PKT_FRAME_MASK) {
   488			/* Disable the WoL */
   489			ret = aqr113c_wol_disable(phydev);
   490			if (ret < 0)
   491				return IRQ_NONE;
   492		}
   493	
   494		irq_status = phy_read_mmd(phydev, MDIO_MMD_AN,
   495					  MDIO_AN_TX_VEND_INT_STATUS2);
   496		if (irq_status < 0) {
   497			phy_error(phydev);
   498			return IRQ_NONE;
   499		}
   500	
   501		if (!(irq_status & MDIO_AN_TX_VEND_INT_STATUS2_MASK))
   502			return IRQ_NONE;
   503	
   504		phy_trigger_machine(phydev);
   505	
   506		return IRQ_HANDLED;
   507	}
   508	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux