On Wed, Jun 28, 2023 at 06:13:24PM +0530, Revanth Kumar Uppala wrote: > Enable MAC controlled energy efficient ethernet (EEE) so that MAC can > keep the PHY in EEE sleep mode when link utilization is low to reduce > energy consumption. This needs more explanation. Is this 'SmartEEE', in that the PHY is doing EEE without the SoC MAC being involved? Ideally, you should only do SmartEEE, if the SoC MAC is dumb and does not have EEE itself. I guess if you are doing rate adaptation, or MACSEC in the PHY, then you might be forced to use SmartEEE since the SoC MAC is somewhat decoupled from the PHY. At the moment, we don't have a good story for SmartEEE. It should be configured in the same way as normal EEE, ethtool --set-eee etc. I've got a rewrite of normal EEE in the works. Once that is merged i hope SmartEEE will be next. Andrew