On Wed, Jun 28, 2023 at 06:13:25PM +0530, Revanth Kumar Uppala wrote: > + /* Lane bring-up failures are seen during interface up, as interface > + * speed settings are configured while the PHY is still initializing. > + * To resolve this, poll until PHY system side interface gets ready > + * and the interface speed settings are configured. > + */ > + ret = phy_read_mmd_poll_timeout(phydev, MDIO_MMD_PHYXS, MDIO_PHYXS_VEND_IF_STATUS, > + val, (val & MDIO_PHYXS_VEND_IF_STATUS_TX_READY), > + 20000, 2000000, false); What does this actually mean when the condition succeeds? Does it mean that the system interface is now fully configured (but may or may not have link)? If that's correct, then that's fine. If it doesn't succeed because the system interface doesn't have link, then that would be very bad, because _this_ function needs to return so the MAC side can then be configured to gain link with the PHY with the appropriate link parameters. The comment doesn't make it clear which it is. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
