On Fri, Jun 16, 2023 at 6:16 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > The drv_reg field is initialized both in the DRV_PINGROUP_ENTRY_N/DRV_PINGROUP_ENTRY_Y > macros and in DRV_PINGROUP_Y. Since each pingroup expands both macros, the are > always duplicate and turning on -Woverride-init (which is disabled by default) > causes a huge amount of warnings like: > > drivers/pinctrl/tegra/pinctrl-tegra234.c:1384:27: error: initialized field overwritten [-Werror=override-init] > 1384 | #define DRV_PINGROUP_Y(r) ((r)) > | ^ > drivers/pinctrl/tegra/pinctrl-tegra234.c:1397:28: note: in expansion of macro 'DRV_PINGROUP_Y' > 1397 | .drv_reg = DRV_PINGROUP_Y(r), \ > | ^~~~~~~~~~~~~~ > drivers/pinctrl/tegra/pinctrl-tegra234.c:1447:49: note: in expansion of macro 'DRV_PINGROUP_ENTRY_Y' > 1447 | #define drive_soc_gpio08_pb0 DRV_PINGROUP_ENTRY_Y(0x500c, 12, 5, 20, 5, -1, -1, -1, -1, 0) > | ^~~~~~~~~~~~~~~~~~~~ > ... > > Remove the intialization that is never used here. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Patch applied! Yours, Linus Walleij
