Hi Uwe, > -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Sent: Monday, April 17, 2023 8:31 AM > To: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Heiko Stuebner <heiko@xxxxxxxxx>; Eddie James <eajames@xxxxxxxxxxxxx>; > Hans Verkuil <hverkuil@xxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; > Dmitry Osipenko <digetx@xxxxxxxxx>; linux-stm32@st-md- > mailman.stormreply.com; Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; linux- > samsung-soc@xxxxxxxxxxxxxxx; Robert Foss <rfoss@xxxxxxxxxx>; Dafna > Hirschfeld <dafna@xxxxxxxxxxxx>; Samuel Holland <samuel@xxxxxxxxxxxx>; Kevin > Hilman <khilman@xxxxxxxxxxxx>; Michal Simek <michal.simek@xxxxxxxxxx>; Antti > Palosaari <crope@xxxxxx>; NXP Linux Team <linux-imx@xxxxxxx>; Jerome Brunet > <jbrunet@xxxxxxxxxxxx>; linux-sunxi@xxxxxxxxxxxxxxx; ye xingchen > <ye.xingchen@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Łukasz > Stelmach <l.stelmach@xxxxxxxxxxx>; Eugen Hristev > <eugen.hristev@xxxxxxxxxxxxx>; Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>; Hyun > Kwon <hyun.kwon@xxxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>; Michael > Tretter <m.tretter@xxxxxxxxxxxxxx>; Moudy Ho <moudy.ho@xxxxxxxxxxxx>; > kernel@xxxxxxxxxxxxxx; Hans Verkuil <hverkuil-cisco@xxxxxxxxx>; Claudiu > Beznea <claudiu.beznea@xxxxxxxxxxxxx>; Ming Qian <ming.qian@xxxxxxx>; > Andrew-CT Chen <andrew-ct.chen@xxxxxxxxxxxx>; Alexandre Belloni > <alexandre.belloni@xxxxxxxxxxx>; Sylwester Nawrocki > <s.nawrocki@xxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx; Yunfei Dong > <yunfei.dong@xxxxxxxxxxxx>; Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>; > Thierry Reding <thierry.reding@xxxxxxxxx>; Guenter Roeck > <groeck@xxxxxxxxxxxx>; chrome-platform@xxxxxxxxxxxxxxx; Jonathan Hunter > <jonathanh@xxxxxxxxxx>; linux-rockchip@xxxxxxxxxxxxxxxxxxx; Fabien Dessenne > <fabien.dessenne@xxxxxxxxxxx>; Ezequiel Garcia > <ezequiel@xxxxxxxxxxxxxxxxxxxx>; Alain Volmat <alain.volmat@xxxxxxxxxxx>; > Andrzej Pietrasiewicz <andrzejtp2010@xxxxxxxxx>; Colin Ian King > <colin.i.king@xxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx; Jacopo Mondi > <jacopo@xxxxxxxxxx>; Rory Liu <hellojacky0226@xxxxxxxxxxx>; Martin > Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; linux-arm- > msm@xxxxxxxxxxxxxxx; Sean Wang <sean.wang@xxxxxxxxxxxx>; Maxime Ripard > <mripard@xxxxxxxxxx>; Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; > linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > Neil Armstrong <neil.armstrong@xxxxxxxxxx>; Zhou Peng <eagle.zhou@xxxxxxx>; > Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>; Maxime Coquelin > <mcoquelin.stm32@xxxxxxxxx>; linux-mediatek@xxxxxxxxxxxxxxxxxxx; Jacek > Anaszewski <jacek.anaszewski@xxxxxxxxx>; Dan Carpenter <error27@xxxxxxxxx>; > Sean Young <sean@xxxxxxxx>; Xavier Roumegue <xavier.roumegue@xxxxxxxxxxx>; > Ettore Chimenti <ek5.chimenti@xxxxxxxxx>; Vikash Garodia > <quic_vgarodia@xxxxxxxxxxx>; linux-tegra@xxxxxxxxxxxxxxx; Eduardo Valentin > <edubezval@xxxxxxxxx>; Andrzej Hajda <andrzej.hajda@xxxxxxxxx>; Fabio > Estevam <festevam@xxxxxxxxx>; Jean-Christophe Trotin <jean- > christophe.trotin@xxxxxxxxxxx>; Stanimir Varbanov > <stanimir.k.varbanov@xxxxxxxxx>; Kieran Bingham > <kieran.bingham@xxxxxxxxxxxxxxxx>; Jernej Skrabec > <jernej.skrabec@xxxxxxxxx>; Chen-Yu Tsai <wens@xxxxxxxx>; Jacob Chen <jacob- > chen@xxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Yang Yingliang > <yangyingliang@xxxxxxxxxx>; Patrice Chotard <patrice.chotard@xxxxxxxxxxx>; > Bin Liu <bin.liu@xxxxxxxxxxxx>; Nathan Chancellor <nathan@xxxxxxxxxx>; > Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; Benson Leung <bleung@xxxxxxxxxxxx>; Daniel W. S. > Almeida <dwlsalmeida@xxxxxxxxx>; Qiheng Lin <linqiheng@xxxxxxxxxx>; Konrad > Dybcio <konrad.dybcio@xxxxxxxxxx>; Kieran Bingham > <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>; Yang Li > <yang.lee@xxxxxxxxxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; > Ricardo Ribalda <ribalda@xxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; > Minghsiu Tsai <minghsiu.tsai@xxxxxxxxxxxx>; Daniel Almeida > <daniel.almeida@xxxxxxxxxxxxx>; Alexandre Torgue > <alexandre.torgue@xxxxxxxxxxx>; Todor Tomov <todor.too@xxxxxxxxx>; Mirela > Rabulea <mirela.rabulea@xxxxxxx>; Ajye Huang <ajye_huang@xxxxxxxxxxx- > partner.google.com>; Scott Chao <scott_chao@xxxxxxxxxxxx- > partner.google.com>; linux-renesas-soc@xxxxxxxxxxxxxxx; Hugues Fruchet > <hugues.fruchet@xxxxxxxxxxx>; openbmc@xxxxxxxxxxxxxxxx; Andy Gross > <agross@xxxxxxxxxx>; Mikhail Ulyanov <mikhail.ulyanov@xxxxxxxxxxxxxxxxxx>; > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; Benoit > Parrot <bparrot@xxxxxx>; Rui Miguel Silva <rmfrfs@xxxxxxxxx>; Christophe > JAILLET <christophe.jaillet@xxxxxxxxxx>; Yong Deng <yong.deng@xxxxxxxxxxxx>; > Matthias Brugger <matthias.bgg@xxxxxxxxx>; Tiffany Lin > <tiffany.lin@xxxxxxxxxxxx>; AngeloGioacchino Del Regno > <angelogioacchino.delregno@xxxxxxxxxxxxx>; Bjorn Andersson > <andersson@xxxxxxxxxx>; Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>; Houlong > Wei <houlong.wei@xxxxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; > Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> > Subject: Re: [PATCH 000/117] media: Convert to platform remove callback > returning void > > Hello Laurent, > > On Mon, Apr 17, 2023 at 09:19:28AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 17, 2023 at 08:02:03AM +0200, Uwe Kleine-König wrote: > > > On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-König wrote: > > > > Hello, > > > > > > > > this series adapts the platform drivers below drivers/pci to use > > > > the > > > > > > copy&paste failure here: s/pci/media/ of course. > > > > > > > .remove_new() callback. Compared to the traditional .remove() > > > > callback > > > > .remove_new() returns no value. This is a good thing because the > > > > driver core doesn't (and cannot) cope for errors during remove. > > > > The only effect of a non-zero return value in .remove() is that > > > > the driver core emits a warning. The device is removed anyhow and > > > > an early return from .remove() usually yields a resource leak. > > > > > > > > By changing the remove callback to return void driver authors > > > > cannot reasonably assume any more that there is some kind of cleanup > later. > > > > > > > > Only three drivers needed some preparation first to make sure they > > > > return 0 unconditionally in their remove callback. Then all > > > > drivers could be trivially converted without side effects to > .remove_new(). > > > > > > > > The changes to the individual drivers are all orthogonal. If I > > > > need to resend some patches because of some review feedback, I'd > > > > like to only send the patches that actually needed changes, so > > > > please pick up the remaining patches that don't need changing to > reduce the amount of mail. > > > > > > I didn't hear anything back about application of this series. Is > > > there a blocker somewhere? > > > > I think the series got applied to the master branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git. > > It should thus appear in v6.4. > > I guess that linux-stable.git is a copy&paste failure (and it's not there). > I don't see the series in the master branch of > git://linuxtv.org/media_tree.git either. > > .. a bit later ... > > ah, it's in git://linuxtv.org/mchehab/media-next.git > > I guess I was just to quick and probably the series will be included in > today's next. I believe patchwork <patchwork@xxxxxxxxxxx> will send notification to author and along with people who applied tags for that patch. I normally get notification from patchwork <patchwork@xxxxxxxxxxx> When the state of patch changes. Cheers, Biju
