Hi, On Wed, Mar 29, 2023 at 08:14:02PM +0300, Ville Syrjala wrote: > diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c b/drivers/gpu/drm/display/drm_scdc_helper.c > index c3ad4ab2b456..2b124152384c 100644 > --- a/drivers/gpu/drm/display/drm_scdc_helper.c > +++ b/drivers/gpu/drm/display/drm_scdc_helper.c > @@ -26,6 +26,8 @@ > #include <linux/delay.h> > > #include <drm/display/drm_scdc_helper.h> > +#include <drm/drm_connector.h> > +#include <drm/drm_device.h> > #include <drm/drm_print.h> > > /** > @@ -140,6 +142,7 @@ EXPORT_SYMBOL(drm_scdc_write); > > /** > * drm_scdc_get_scrambling_status - what is status of scrambling? > + * @connector: connector > * @adapter: I2C adapter for DDC channel > * > * Reads the scrambler status over SCDC, and checks the > @@ -148,14 +151,17 @@ EXPORT_SYMBOL(drm_scdc_write); > * Returns: > * True if the scrambling is enabled, false otherwise. > */ > -bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > +bool drm_scdc_get_scrambling_status(struct drm_connector *connector, > + struct i2c_adapter *adapter) Is there any driver where adapter isn't equal to connector->ddc? If not, there's no reason to pass both Maxime
