Re: [PATCH] arm64: dts: smaug: Add EMC frequency change tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/03/2023 12:34, Diogo Ivo wrote:
> On Mon, Mar 20, 2023 at 07:50:27AM +0100, Krzysztof Kozlowski wrote:
>> On 19/03/2023 20:42, Diogo Ivo wrote:
>>> +	emc: external-memory-controller@7001b000 {
>>
>> Node names should be generic, so memory-controller.
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> Check your code for warnings (dtc, dtbs_check). Node with unit address
>> requires reg or ranges.
>>
>> Best regards,
>> Krzysztof
> 
> 
> Hello,
> 
> The external-memory-controller node is declared in tegra210.dtsi, so
> here I am just adding more properties to it.

Ah, ok, apologies then for false alarm. This Tegra notation of extending
existing nodes is crazy confusing...

Best regards,
Krzysztof




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux