On 14/03/2023 09:34, Hans Verkuil wrote: > On 13/03/2023 23:01, Guenter Roeck wrote: >> On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: >>> The driver can match only via the DT table so the table should be always >>> used and the of_match_ptr does not have any sense (this also allows ACPI >>> matching via PRP0001, even though it might not be relevant here). >>> >>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> >> >> FWIW: There is also >> https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@xxxxxxxxxxxx/ > > I superseded that patch in patchwork in favor of this patch since this is part of > a larger series. I am personally fan of FIFO, so Guenter's patch should go in. > > Krzysztof, please let me know if you will take this series yourself or want me to > make a PR for it. I prefer if you take entire patchset. Best regards, Krzysztof
