On 08/03/2023 19:45, Dipen Patel wrote: > On 2/16/23 6:17 AM, Krzysztof Kozlowski wrote: >> On 14/02/2023 12:55, Dipen Patel wrote: >>> Added timestamp provider support for the Tegra234 in devicetree >>> bindings. >> >> 1. Your commit does much more. You need to explain it why you drop some >> property. > ACK, will address it next patch >> >> 2. Bindings go before its usage (in the patchset). > Ack... >> >> 3. Please use scripts/get_maintainers.pl to get a list of necessary >> people and lists to CC. It might happen, that command when run on an >> older kernel, gives you outdated entries. Therefore please be sure you >> base your patches on recent Linux kernel. > It is based on recent linux at the time patch series was sent... That's good but then why you do not use scripts/get_maintainers.pl? The hint about recent kernel was just a hint... Just do not invent addresses by yourself and use the tool to get them right. (...) >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - nvidia,tegra194-gte-aon >> >> This is an ABI break. Does your driver handle it? > yes, handling patch is part of this patch series. Can you point me to the code which does it? I see "return -ENODEV;", so I think you do not handle ABI break. I could miss something but since you disagree with me, please at least bring some arguments... Best regards, Krzysztof
