On 21/02/2023 19:32, Svyatoslav Ryhel wrote: > From: David Heidelberg <david@xxxxxxx> > > Add dt-binding for RT5631 CODEC. > > Signed-off-by: David Heidelberg <david@xxxxxxx> > --- > .../sound/nvidia,tegra-audio-rt5631.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml > new file mode 100644 > index 000000000000..b347f34c47f2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra-audio-rt5631.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra audio complex with RT5631 CODEC > + > +maintainers: > + - Jon Hunter <jonathanh@xxxxxxxxxx> > + - Thierry Reding <thierry.reding@xxxxxxxxx> > + > +allOf: > + - $ref: nvidia,tegra-audio-common.yaml# > + > +properties: > + compatible: > + items: > + - pattern: '^[a-z0-9]+,tegra-audio-rt5631(-[a-z0-9]+)+$' > + - const: nvidia,tegra-audio-rt5631 > + > + nvidia,audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: | > + A list of the connections between audio components. > + Each entry is a pair of strings, the first being the connection's sink, > + the second being the connection's source. Valid names for sources and > + sinks are the pins (documented in the binding document), > + and the jacks on the board. > + minItems: 2 > + items: > + enum: > + # Board Connectors > + - "Int Spk" > + - "Headphone Jack" > + - "Mic Jack" > + - "Int Mic" > + > + # CODEC Pins > + - MIC1 > + - MIC2 > + - AXIL > + - AXIR > + - MONOIN_RXN > + - MONOIN_RXP > + - DMIC > + - MIC Bias1 > + - MIC Bias2 > + - MONO_IN > + - AUXO1 > + - AUXO2 > + - SPOL > + - SPOR > + - HPOL > + - HPOR > + - MONO > + > +required: > + - nvidia,i2s-controller By convention we always require compatible (and your common schema does not require it, I think). The same for your other patches. Best regards, Krzysztof
