On Mon, Feb 27, 2023 at 01:34:55PM +0000, Jon Hunter wrote:
>
>
> On 16/01/2023 10:19, Sushil Singh wrote:
> > Add mgbe ethernet GPIO wake interrupt
>
> Add the GPIO wake interrupt for the MGBE ethernet controller on Tegra234
> devices.
>
> >
> > Signed-off-by: Sushil Singh <sushilkumars@xxxxxxxxxx>
> > ---
> > drivers/soc/tegra/pmc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> > index cf4cfbf..f4abc7f 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> > * drivers/soc/tegra/pmc.c
> > *
> > * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2022, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > *
> > * Author:
> > * Colin Cross <ccross@xxxxxxxxxx>
> > @@ -4227,6 +4227,7 @@ static const char * const tegra234_reset_sources[] = {
> > static const struct tegra_wake_event tegra234_wake_events[] = {
> > TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> > TEGRA_WAKE_IRQ("rtc", 73, 10),
> > + TEGRA_WAKE_GPIO("mgbe_wake", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
>
> Just 'mgbe' is sufficient.
>
> > };
> > static const struct tegra_pmc_soc tegra234_pmc_soc = {
>
> Please check the subject prefix for the subsystem by looking at the git
> history ...
>
> $ git log --oneline drivers/soc/tegra/pmc.c
> 0474cc8489bd soc/tegra: pmc: Process wake events during resume
> 1ddb8f6d44ff soc/tegra: pmc: Fix dual edge triggered wakes
> c9c4ddb20c42 soc/tegra: pmc: Add I/O pad table for Tegra234
> 74f7f183d81c soc/tegra: pmc: Check device node status property
> ...
>
> So the subject should start "soc/tegra: pmc: ". Also remove the '.' from the
> end of the subject.
>
> Finally, please use 'MGBE' in the subject and description.
Also, for these kinds of highly Tegra-specific patches, there's no need
to include the netdev mailing list. This is entirely about integration
of the MGBE in some Tegra-specific IP, so I don't expect anyone from
netdev to have any interest in this.
Thierry
Attachment:
signature.asc
Description: PGP signature
