On 2/8/23 11:03 PM, Andy Shevchenko wrote: > From: Linus Walleij <linus.walleij@xxxxxxxxxx> > > The test driver uses the gpiod consumer API so include the right > <linux/gpio/consumer.h> header. This may cause a problem with > struct of_device_id being implcitly pulled in by the legacy > header <linux/gpio.h> so include <linux/mod_devicetable.h> > explicitly as well. > > While at it, drop explicit moduleparam.h (it's included with module.h) > and sort the headers. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/hte/hte-tegra194-test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c > index 5d776a185bd6..358d4a10c6a1 100644 > --- a/drivers/hte/hte-tegra194-test.c > +++ b/drivers/hte/hte-tegra194-test.c > @@ -6,14 +6,14 @@ > */ > > #include <linux/err.h> > -#include <linux/module.h> > -#include <linux/moduleparam.h> > +#include <linux/gpio/consumer.h> > +#include <linux/hte.h> > #include <linux/interrupt.h> > -#include <linux/gpio.h> > -#include <linux/timer.h> > +#include <linux/mod_devicetable.h> > +#include <linux/module.h> > #include <linux/platform_device.h> > +#include <linux/timer.h> > #include <linux/workqueue.h> > -#include <linux/hte.h> > > /* > * This sample HTE GPIO test driver demonstrates HTE API usage by enabling Acked-by: Dipen Patel <dipenp@xxxxxxxxxx>
