Re: [PATCH 1/3] dt-bindings: pinctrl: tegra234: Add DT binding doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 07, 2023 at 08:37:51AM -0600, Rob Herring wrote:
> 
> On Tue, 07 Feb 2023 17:26:15 +0530, Prathamesh Shete wrote:
> > Add DT binding doc for Tegra234 pinmux driver.
> > 
> > Signed-off-by: Prathamesh Shete <pshete@xxxxxxxxxx>
> > ---
> >  .../pinctrl/nvidia,tegra234-pinmux.yaml       | 232 ++++++++++++++++++
> >  1 file changed, 232 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.example.dtb: pinmux@2430000: pinmux-pex-rst-c5-out:pex_rst:nvidia,pins:0: 'pex_l5_rst_n_pgg1' is not one of
[...]

Prathamesh,

Looks like maybe you copied the example from Tegra194. On Tegra234 I
think the corresponding GPIO is AF1, so the full pin name for this is
pex_l5_rst_n_paf1.

Please fix and make sure to run the DT binding check before sending out
v2.

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux