Hi, On Tue, Feb 07, 2023 at 08:19:04PM +0100, Uwe Kleine-König wrote: > Hello, > > while checking in which cases hda_tegra_remove() can return a non-zero value, I > found that actually cannot happen. This series makes the involved functions > return void to make this obvious. > > This is a preparation for making platform_driver::remove return void, too. > > Best regards > Uwe > > Uwe Kleine-König (3): > ALSA: core: Make snd_card_disconnect() return void > ALSA: core: Make snd_card_free_when_closed() return void > ALSA: core: Make snd_card_free() return void > > include/sound/core.h | 6 +++--- > sound/core/init.c | 40 ++++++++++++++------------------------- > sound/pci/hda/hda_tegra.c | 6 ++---- > sound/ppc/snd_ps3.c | 4 +--- > 4 files changed, 20 insertions(+), 36 deletions(-) All of the changes in the patches look good to me, as the return value seems not to be so effective for a long time (15 years or more) and expected so for future. Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx> One of my concern is that we are mostly in the last week for v6.3 development. When taking influence of the changes into account, it would be possible to postpone to v6.4 development. But it's up to the maintainer. > base-commit: 05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a A small nitpicking. I think you use Linus' tree or so: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=05ecb680708a Because the hash is not reachable from the branch for next merge window on the tree of sound subsystem upstream: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-next&id=05ecb680708a I guess it is safer to use his tree as your work-base, even if the three patches can be applied to it as is (fortunately). Regards Takashi Sakamoto
