Hi Uwe, On 2/7/23 11:19, Uwe Kleine-König wrote: > The function returns 0 unconditionally. Make it return void instead and > simplify all callers accordingly. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > include/sound/core.h | 2 +- > sound/core/init.c | 6 ++---- > sound/pci/hda/hda_tegra.c | 6 ++---- > sound/ppc/snd_ps3.c | 4 +--- > 4 files changed, 6 insertions(+), 12 deletions(-) > --- a/sound/ppc/snd_ps3.c > +++ b/sound/ppc/snd_ps3.c > @@ -1053,9 +1053,7 @@ static void snd_ps3_driver_remove(struct ps3_system_bus_device *dev) > * ctl and preallocate buffer will be freed in > * snd_card_free > */ > - ret = snd_card_free(the_card.card); > - if (ret) > - pr_info("%s: ctl freecard=%d\n", __func__, ret); > + snd_card_free(the_card.card); > > dma_free_coherent(&dev->core, > PAGE_SIZE, Looks OK for PS3. Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx>