Hi Thierry, did you have the time to look at the get_thermal_instance() removal ? On 26/01/2023 13:55, Thierry Reding wrote:
[ 12.354091] tegra_soctherm 700e2000.thermal-sensor: missing thermtrips, will use critical trips as shut down temp [ 12.379009] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when cpu reaches 102500 mC [ 12.388882] tegra_soctherm 700e2000.thermal-sensor: programming throttle for cpu to 102500 [ 12.401007] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when cpu reaches 102500 mC [ 12.471041] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when gpu reaches 103000 mC [ 12.482852] tegra_soctherm 700e2000.thermal-sensor: programming throttle for gpu to 103000 [ 12.482860] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when gpu reaches 103000 mC [ 12.485357] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when pll reaches 103000 mC [ 12.501774] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when mem reaches 103000 mC and after these changes, it turns into: [ 12.447113] tegra_soctherm 700e2000.thermal-sensor: missing thermtrips, will use critical trips as shut down temp [ 12.472300] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when cpu reaches 102500 mC [ 12.481789] tegra_soctherm 700e2000.thermal-sensor: programming throttle for cpu to 102500 [ 12.495447] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when cpu reaches 102500 mC [ 12.496514] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when gpu reaches 103000 mC [ 12.510353] tegra_soctherm 700e2000.thermal-sensor: programming throttle for gpu to 103000 [ 12.526856] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when gpu reaches 103000 mC [ 12.528774] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when pll reaches 103000 mC [ 12.569352] tegra_soctherm 700e2000.thermal-sensor: programming throttle for pll to 103000 [ 12.577635] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when pll reaches 103000 mC [ 12.590952] tegra_soctherm 700e2000.thermal-sensor: thermtrip: will shut down when mem reaches 103000 mC [ 12.600783] tegra_soctherm 700e2000.thermal-sensor: programming throttle for mem to 103000 [ 12.609204] tegra_soctherm 700e2000.thermal-sensor: throttrip: will throttle when mem reaches 103000 mC The "programming throttle ..." messages are something I've added locally to trace what gets called. So it looks like for "pll" and "mem" thermal zones, we now program trip points whereas we previously didn't. I'll take a closer look to see if we can replace the calls to get_thermal_instance() by something else. Thierry
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
