Hi Vinod,
On Tue, Jan 24, 2023 at 7:37 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> While there exist several optional_get() PHY helper functions, there is
> no optional variant of devm_of_phy_get(), leading to several drivers
> implementing this theirselves, sometimes in buggy ways.
>
> Hence this series, after two cleanup patches, introduces a
> devm_of_phy_optional_get() helper(), and converts existing users of
> devm_of_phy_get() where appropriate.
>
> Changes compared to v1[1]:
> - Incorporate "[PATCH v2 1/9] phy: Remove unused phy_optional_get()",
> as it touches the same documentation,
> - New patch "[PATCH v2 2/9] doc: phy: Document devm_of_phy_get()",
> - Print an error message in case of failure, as requested by RobH,
> - Update Documentation,
> - Clarify removed checks for -ENODEV and -ENOSYS,
> - Remove error printing in case of real failures from callers,
> - Rebase am65-cpsw change on top of commit 854617f52ab42418 ("net:
> ethernet: ti: am65-cpsw: Handle -EPROBE_DEFER for Serdes PHY") in
> net-next (next-20230123 and later),
> - Add Reviewed-by, Acked-by.
>
> Most of this series been compile-tested only, but the new helper itself
> has been tested with a new user[2].
Are you happy with this? This series (at least patch 3) is a dependency
for [2], and in [3] you said you could apply it and create an immutable
branch.
Thanks!
> [1] "[PATCH treewide 0/7] phy: Add devm_of_phy_optional_get() helper"
> https://lore.kernel.org/r/cover.1674036164.git.geert+renesas@xxxxxxxxx
> [2] "[PATCH 12/12] can: rcar_canfd: Add transceiver support"
> https://lore.kernel.org/r/e825b50a843ffe40e33f34e4d858c07c1b2ff259.1674499048.git.geert+renesas@xxxxxxxxx
[3] https://lore.kernel.org/all/Y8kmG+jB%2Fs7stebA@matsya
>
> Geert Uytterhoeven (9):
> phy: Remove unused phy_optional_get()
> doc: phy: Document devm_of_phy_get()
> phy: Add devm_of_phy_optional_get() helper
> net: fman: memac: Convert to devm_of_phy_optional_get()
> net: lan966x: Convert to devm_of_phy_optional_get()
> net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get()
> PCI: tegra: Convert to devm_of_phy_optional_get()
> usb: host: ehci-exynos: Convert to devm_of_phy_optional_get()
> usb: host: ohci-exynos: Convert to devm_of_phy_optional_get()
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
