Hi, > -----Original Message----- > From: Jonathan Hunter <jonathanh@xxxxxxxxxx> > Sent: Wednesday, February 1, 2023 12:23 PM > To: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Thierry Reding > <thierry.reding@xxxxxxxxx>; Wolfram Sang <wsa+renesas@sang- > engineering.com>; Ajay Gupta <ajayg@xxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; Wayne Chang <waynec@xxxxxxxxxx> > Subject: Re: [PATCH V10 4/6] i2c: nvidia-gpu: Remove ccgx,firmware-build > property > > Adding Ajay as well. > > On 01/02/2023 16:01, Jon Hunter wrote: > > Adding Wolfram. > > > > On 31/01/2023 17:57, Jon Hunter wrote: > >> From: Wayne Chang <waynec@xxxxxxxxxx> > >> > >> Now the Cypress CCG driver has been updated to support the > >> 'firmware-name' property to align with device-tree, remove the > >> 'ccgx,firmware-build' property as this is no longer needed. Acked-by: Ajay Gupta <ajayg@xxxxxxxxxx> Thanks > >> nvpublic > >> > >> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx> > >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > >> --- > >> V6 -> V10: no changes > >> V5: Added this patch from V3 > >> > >> drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c > >> b/drivers/i2c/busses/i2c-nvidia-gpu.c > >> index 6d81ea530a83..a8b99e7f6262 100644 > >> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > >> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > >> @@ -259,8 +259,7 @@ static const struct pci_device_id gpu_i2c_ids[] = > >> { > >> MODULE_DEVICE_TABLE(pci, gpu_i2c_ids); > >> static const struct property_entry ccgx_props[] = { > >> - /* Use FW built for NVIDIA (nv) only */ > >> - PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'), > >> + /* Use FW built for NVIDIA GPU only */ > >> PROPERTY_ENTRY_STRING("firmware-name", "nvidia,gpu"), > >> { } > >> }; > > > > -- > nvpublic