Hello,
On Fri, Dec 23, 2022 at 03:33:40PM +0000, Rayyan Ansari wrote:
> On 25/10/2022 16:37, Diogo Ivo wrote:
> > +config DRM_PANEL_JDI_LPM102A188A
> > + tristate "JDI LPM102A188A DSI panel"
> > + depends on OF && GPIOLIB
> > + depends on DRM_MIPI_DSI
> > + depends on BACKLIGHT_CLASS_DEVICE
> > + help
> > + Say Y here if you want to enable support for JDI LPM102A188A DSI
> > + control mode panel as found in Google Pixel C devices.
> Shouldn't this be "command mode panel" instead of "control mode panel"?
Yes, it should.
> > +static struct mipi_dsi_driver jdi_panel_dsi_driver = {
> > + .driver = {
> > + .name = "panel-jdi-lpm102a188a-dsi",
> Is the "-dsi" suffix needed here? Other panel drivers don't have this.
I had not noticed this, and I will drop it.
Thank you for your review and attention to detail. I will address these
points in the next version.
Diogo Ivo
