On 06/12/2022 17:36, Thierry Reding wrote: > On Mon, Dec 05, 2022 at 04:18:44PM +0100, Krzysztof Kozlowski wrote: >> Convert Nvidia Tegra HDMI CEC bindings to DT schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> >> --- >> .../bindings/media/cec/nvidia,tegra-cec.yaml | 58 +++++++++++++++++++ >> .../devicetree/bindings/media/tegra-cec.txt | 27 --------- >> MAINTAINERS | 2 +- >> 3 files changed, 59 insertions(+), 28 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml >> delete mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt >> >> diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml >> new file mode 100644 >> index 000000000000..9a4025ff7fad >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra-cec.yaml > > For consistency with other DT bindings on Tegra, it'd be good to name > this nvidia,tegra114-cec.yaml since that's the first generation where > this IP was added. Not a big deal, though. Sure, I can rename it. > >> @@ -0,0 +1,58 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/cec/nvidia,tegra-cec.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nvidia Tegra HDMI CEC > > Again, for consistency with other bindings, NVIDIA is the preferred > spelling. It's not a big deal and could be fixed up in a subsequent > patch, there are a few other cases where the alternative spelling has > been used. > > The rest looks okay, so either way: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> OK Best regards, Krzysztof
