On Mon, Dec 05, 2022 at 07:03:09PM +0000, Robin Murphy wrote: > On 2022-12-02 15:26, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Access to the internals of struct iommu_fwspec by non-IOMMU drivers is > > discouraged. Many drivers for Tegra SoCs, however, need access to their > > IOMMU stream IDs so that they can be programmed into various hardware > > registers. > > > > Formalize this access into a common helper to make it easier to audit > > and maintain. > > In many ways I'd be happier if this could go somewhere in include/soc/tegra/ > rather than the generic IOMMU API header, but I see the argument for keeping > fwspec usage close to home as well, so no overwhelming preference one way or > the other. Mostly I'd just like to get something landed so that all those > other drivers can be cleaned up as well, and I reckon this counts as good > enough. Yeah, given Joerg's comment about potentially hiding struct iommu_fwspec better from others at some point in the future, I figured it'd be better to have this in a more central location. > Unless Joerg has a stronger opinion, > > Acked-by: Robin Murphy <robin.murphy@xxxxxxx> Thanks, Thierry
Attachment:
signature.asc
Description: PGP signature
