On Fri, Nov 4, 2022 at 3:23 PM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > This patch series changes the pin controller DT description on Tegra194 > in order to properly describe how the hardware works. Currently a > simplified description is used that merges two pin controller instances > (called AON and main) into a single DT node. This has some disadvantages > such as creating a complicated mapping between the pins in those pin > controllers and the corresponding GPIO controllers (which are already > separated). > > As a prerequisite, the first patch in this series converts the device > tree bindings to json-schema. A second patch then adds an additional > compatible string for the AON instance (along with more details about > each controller's pins) and finally patch 3 converts the driver to > cope with these changes. A fourth patch makes the corresponding > changes in the Tegra194 DTS file. > > Note that while this changes the DT node in an incompatible way, this > doesn't have any practical implications for backwards-compatibility. The > reason for this is that device trees have only reconfigured a very > narrow subset of pins of the main controller, so the new driver will > remain backwards-compatible with old device trees. > > Changes in v3: > - address more review comments by Rob Herring and make validation work This looks good to me! I tried to apply them to the pinctrl devel branch but this happens: $ git am --signoff ./v3_20221104_thierry_reding_pinctrl_tegra_separate_tegra194_instances.mbx Applying: dt-bindings: pinctrl: tegra: Convert to json-schema error: Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.yaml: does not exist in index Patch failed at 0001 dt-bindings: pinctrl: tegra: Convert to json-schema I guess there are some prerequisites? Yours, Linus Walleij